Question
Alfa Bank
RU
Last activity: 14 Aug 2019 0:31 EDT
Unreleased resource: stream in activity InvokeAxis2
Hello, Team.
Can anyone explain me why there is no close method called after reading from data source stream inside activity InvokeAxis2?
try {
java.io.InputStream in = dataSource.getInputStream();
byte[] buf = new byte[in.available()];
in.read(buf);
String attachVal = Base64Util.encodeToString(buf);
attachKeys.add(attachKey);
attachVals.add(attachVal);
attachTypes.add(attachType);
} catch (Throwable e) {
throw new ConnectorException("Couldn't serialize attachment to string value", e);
}
I'm using Pega 7.2.2. Activity InvokeAxis2 is located in Rule-Connect-SOAP class. Pega-IntegrationEngine:07-10-27 ruleset.
Regards,
Alex
Pegasystems Inc.
US
In general, you should add a finally clause in the code above:
finally {
try {
if (in != null)
in.close();
} catch (java.io.IOException ex) {
oLog.error("Error occured while closing inputstream");
}
}
Alfa Bank
RU
Hi, Kevin
Thank you for your reply.
I know how stream closing should be done. I ask, why there is no stream close method call inside Pega OOTB activity?
Regards
Infosys Limited
IN
Hi Alex,
If you go through java code then you can see, pega is catching all Throwable (catch (Throwable e)) in Catch block. In java , 'Throwable' is the top most class in exception hierarchy. So in all exception scenario, it will throw 'ConnectorException' and exception handling are being done in ConnectorException. No need of 'Closing (Finally)' block.
Java Exception hierarchy:
http://www.benchresources.net/exception-hierarchy-in-java/
Hope this will answer your question.
Thanks
Alfa Bank
RU
Hi, Pravin.
I'm asking why there is no close method for opened stream?
It should be like:
try {
InputStream in = dataSource.getInputStream();
byte[] buf = new byte[in.available()];
in.read(buf);
} catch (Exception e) {
// Handle exception
} finally {
in.close();
}
Not closed stream can lead to memory leaks.
Regards
Pegasystems Inc.
IN
Hi Alex,
Try with resources is also an alternative approach to do the same in which there is no requirement to close the streams explicitly by calling close() method.
Could you please let us know about the step containing this code snippet under InvokeAxis2 activity?
Regards