Question
Wipro
US
Last activity: 20 Dec 2016 5:27 EST
Code Review using Custom fields
Hi, I have a requirement to do code review in Pega and generate a report on what % of code is being reviewed. I thought of using custom fields in Pega rule form (under history tab of any rule) and add a code review property and update it when ever code re view is done and generate a report from it. but it is final rule and I cant do any modifications to it. Also its a page group and static as well. lets say on 11/01 i did a code review and add a comment and on 12/01 if I have to d again, Pega will override the property value and I loose the previous changes. What is the best way of doing Code review in pega and how can I run reports from it?
Sri.
Pegasystems Inc.
US
Hi Sridhar,
I'm not sure exactly what you mean. Are you just trying to track that a code review was done for a given rule? Trying to track what percentage of the rule was reviewed seems incredibly error prone/open for interpretation. Are you limiting this to activities and data transforms? Do you base percentage on the number of steps (i.e. I've reviewed the first 3 steps of a 10 step activity, I've done 30%)? How does something like a Java step factor into all of this? For UI rules, how do you judge the review of the various controls and includes, and the values passed into them?
Does the tracking have to be associated directly with the ruleform or can you possibly create an activity that you run against a given rule to add an entry to a database table with the rule, the date/time, and whatever notes you want? Then you can report off that table. Or if you require the review before you all rule check in, you could put the review notes in there? That would be viewable from the history tab.
Thanks,
Mike
Pegasystems Inc.
IN
Hi Sri, Good Morning!
would the option 'Approval required' on ruleset rule from works?
- designerStudio --> process & rules --> tools --> my work --> work by work basket ([email protected])
- for every check-in an approval workobject (RC-*) will be created where we might attempt to maintain the track changes...
Please share your thoughts/comments, Thank you!
psahukaru
Wipro
US
Thanks for the update Mike and Phani. My requirement is when ever a lead wants to do code review in Pega for specific functionality, there should open the rule, review it and add a comment for code review done or add a review comment to the rule. This should be ongoing process in dev. The comments are more or like overall for a rule but not partial (to start with). End of every week/month, manager wants to review what % of code being reviewed by the lead. Generate a report out of it.
Phani, the check in approval is useful but it is really tedious many times. Dev team cant work till approval is done and lead has to review more than 100 rules a day which might not possible with our deadlines. So instead of approving every check-in, lead should spend some time during a week/month and review rules and add comments. Hope this helps.
Sri.